Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
1862/fix setprops on cdu #2007
We noticed a regression in our test suite (between Enzyme 3.8 and 3.9), likely due to this patch. Downgrading to Enzyme 3.8 makes our test suite pass again.
We have some code that changes a component's
This PR shows the regression as well as the revert to Enzyme 3.8 to get a green CI again: mozilla/addons-frontend#7603.
I am not sure what you or I could do though. Moving away from CWRP is on our roadmap and might "fix" this incompatibility, but upgrading from 3.8 to 3.9 should not break our test suite. I don't know what's the most "correct" behavior between no batch updates, the <=3.8 behavior and the new one introduced by this patch