Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enzyme-adapter-react-16] [fix] Find memo components by constructor #2081

Merged
merged 1 commit into from Apr 3, 2019

Conversation

Projects
None yet
2 participants
@eps1lon
Copy link
Contributor

eps1lon commented Apr 3, 2019

Follow up on 4149a21 which attempted to fix #2038. The fix was not working for the scenario described in #2038 (comment).

This PR adds a test for the scenario above and fixes that issue.

@ljharb

ljharb approved these changes Apr 3, 2019

Copy link
Member

ljharb left a comment

Thanks, this is excellent and much appreciated.

@ljharb ljharb force-pushed the eps1lon:test/memo-find branch from 1ee134f to 3045286 Apr 3, 2019

@ljharb ljharb merged commit 3045286 into airbnb:master Apr 3, 2019

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eps1lon eps1lon deleted the eps1lon:test/memo-find branch Apr 3, 2019

ljharb added a commit that referenced this pull request Apr 6, 2019

[enzyme-adapter-react-16] v1.12.0
 - [new] Add support for wrapping `Profiler` (#2055)
 - [new] support shallow rendering `createContext()` providers and consumers  - add `isContextConsumer`, `getProviderFromConsumer` (#1966)
 - [new] add `wrapWithWrappingComponent`, `isCustomComponent` (#1960)
 - [new] add `getDerivedStateFromError` support (#2036)
 - [fix] avoid invariant violation in provider (#2083)
 - [fix] properly fix finding memo(SFC) components (#2081)
 - [fix] properly render memoized SFCs
 - [fix] `shallow`: avoid wrapping component for hooks
 - [deps] update `react-is`
 - [dev deps] update `eslint`
 - [refactor] use `react-is` predicates more
 - [build] include source maps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.