Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to new Preact adapter in README #2089

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
2 participants
@robertknight
Copy link
Contributor

robertknight commented Apr 9, 2019

A new Preact adapter for Enzyme is available under the Preact org on GitHub. This PR replaces the link in the README with a reference to the newer one.

This adapter supports all three Enzyme rendering modes as well as the upcoming
Preact v10 release (which is a rewrite of the internals). It also avoids an indirect dependency on React and the need to install the React-compatibility layer in order to use it.

As an aside, as part of this project some work was done to create type definitions for Enzyme adapter authors to use. Would there be interest in moving those upstream into enzyme itself at some point?

[Docs] Add link to new Preact adapter in README
Replace the link to the Preact adapter with the newer one from the
Preact org on GitHub.

This adapter supports all three Enzyme rendering modes as well as the upcoming
Preact v10 release (which is a rewrite of the internals).

It also avoids an indirect dependency on React and the need to install the
React-compatibility layer in order to use it.
@ljharb

ljharb approved these changes Apr 10, 2019

Copy link
Member

ljharb left a comment

Thanks for updating the link!

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Apr 10, 2019

As far as type defs, I might consider upstreaming them at some point, but TypeScript still has a few bugs I'd need to see resolved first (for example, using Symbols as an index key, and I'm not sure the react element types do the right thing just yet).

@ljharb ljharb added the docs label Apr 10, 2019

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Apr 10, 2019

In the meantime, though, I'd suggest upstreaming those types into DefinitelyTyped.

@ljharb ljharb force-pushed the robertknight:update-preact-adapter-link branch from ef0b92e to 3cc2e92 Apr 10, 2019

@ljharb ljharb merged commit 3cc2e92 into airbnb:master Apr 10, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 91.502%
Details

@robertknight robertknight deleted the robertknight:update-preact-adapter-link branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.