Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format all `.babelrc` files to off warning #2329

Closed

Conversation

@lamhieu-vk
Copy link
Contributor

lamhieu-vk commented Feb 8, 2020

馃拑

@lamhieu-vk lamhieu-vk requested a review from ljharb Feb 8, 2020
Copy link
Collaborator

ljharb left a comment

This is not a positive change; why are you ruining the formatting of these valid babelrc files? rc files don't have to be strictly json.

@lamhieu-vk

This comment has been minimized.

Copy link
Contributor Author

lamhieu-vk commented Feb 9, 2020

hi @ljharb , I know files don't have to be strictly json but I think bringing it back to json format will make it look better 馃拑 If you think we don't need it, please close PR ^^.

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Feb 9, 2020

In general, aesthetic preferences are up to the maintainers of a project, and aren't really appropriate things for contributors to suggest. Thanks for the PR!

@ljharb ljharb closed this Feb 9, 2020
@ljharb ljharb added the wontfix label Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can鈥檛 perform that action at this time.