Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Package cloud #181
We were under the impression that this project and hypernova-ruby weren't actively maintained due to the reduced contributions/interactions lately.
Let me give you some context:
We noticed a bug awhile ago where unescaped HTML characters were causing a JSON.parse error, breaking the JS on some of our views. The original attempt to rectify this was here: airbnb/hypernova-ruby#22
The issue is that certain browsers will take a prop like
I've been looking into this one for the past little while and I guess that hypernova-ruby performs that escaping through the BlankRenderer when the hypernova server is unavailable right? So a more complete solution would be to implement more thorough escaping on hypernova and its client libraries to cover all scenarios.
tl;dr we feel we should be escaping these other characters for safety and to protect against the current breakages we're experiencing.
Looking again at the original PR I'm inclined to agree that JSON escaping would be more appropriate, but anxious to hear what you think.