why is space-in-parens disabled?

[pigoz]

Hello! This is a question not a bug :)

Looking at your examples you always use the following style: if (x) {, functionCall(a, b, c). So, I was wondering why is space-in-parens completely disabled in your eslint config?

[ljharb]

Where exactly would you expect to put the spaces in the parens there? Per our current style, there's spaces inside braces ({ }), but there shouldn't be any inside parens (( )) or brackets ([ ]).

[pigoz]

I was thinking "space-in-parens": [2, "never"] might reflect better what is written in the styleguide.

Right now I am not getting any linting warnings when adding a space inside parens or brackets.

EDIT: looks like the following would match more closely the written syleguide (unless I am missing something obvious?).

"space-in-parens": [2, "never"],
"array-bracket-spacing": [2, "never"],
"computed-property-spacing": [2, "never"],
"object-curly-spacing": [2, "always"]

[ljharb]

Looks like you're right, thanks for elaborating! a PR to apply those settings is welcome.

[pigoz]

I created the PR. Closing this issue!

[ljharb]

Let's leave the issue open until the PR is merged, which will auto-close the issue :-)

[mgcrea]

Why use a different rule for objects? Imo "object-curly-spacing": [2, "always"] should be switched to never to follow array-bracket-spacing.

Either its {foo: 'bar'} and ['foo', 'bar'], or it's { foo: 'bar' } and [ 'foo', 'bar' ], but a mix of both is awkward & confusing.