Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate `strict` rule definition between airbnb and airbnb-base #1962

Merged
merged 3 commits into from Aug 10, 2019

Conversation

@edmorley
Copy link
Contributor

commented Nov 20, 2018

See individual commit messages for more details.

Fixes #1582.

edmorley added some commits Nov 20, 2018

[eslint config] [base] [breaking] Set 'strict' to 'never'
Previously `rules/strict.js` was only used by `eslint-config-airbnb`
and not base. This change reduces the duplication, and means the rule
is now set to 'never' as opposed to the ESLint default of 'safe'.

For users that left the `sourceType` at this preset's default of
`module` this change will be a no-op, since in module-mode the
`strict` rule always behaves as though 'never' had been set.

See:
https://eslint.org/docs/rules/strict#options
[eslint config] Remove rules/strict from 'extends'
Since the file is now imported in base instead.

Fixes #1582.
@ljharb
Copy link
Collaborator

left a comment

LGTM, but i'm going to hold off merging this until other semver-major changes are ready.

@edmorley edmorley force-pushed the edmorley:cleanup-strict-rule branch from b24ffd5 to fee92ba Jun 23, 2019

@edmorley

This comment has been minimized.

Copy link
Contributor Author

commented Jun 23, 2019

I've rebased on master to resolve the conflicts, given the next major release is likely to be not too far out :-)

@ljharb ljharb force-pushed the edmorley:cleanup-strict-rule branch from fee92ba to ad0c44c Aug 10, 2019

@ljharb

ljharb approved these changes Aug 10, 2019

Copy link
Collaborator

left a comment

'use time to merge;'

@ljharb ljharb merged commit ad0c44c into airbnb:master Aug 10, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@edmorley edmorley deleted the edmorley:cleanup-strict-rule branch Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.