New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parenthesis #1985

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@leonidlebedev
Copy link
Contributor

leonidlebedev commented Jan 6, 2019

No description provided.

@@ -436,7 +436,7 @@ We don’t recommend using indexes for keys if the order of items may change.
isPublished: false
}
return (<div {...props} />);
return <div {...props} />;

This comment has been minimized.

@ljharb

ljharb Jan 6, 2019

Member

although parents are not required on single-line jsx, they are certainly permitted and encouraged.

This comment has been minimized.

@leonidlebedev

leonidlebedev Jan 6, 2019

Contributor

There are two examples where we use brackets. I decided to remove them for consistency.

This comment has been minimized.

@ljharb

ljharb Jan 6, 2019

Member

Consistency is good when one form is preferred; in this case i think the inconsistency is better because it demonstrates that either form is acceptable

@leonidlebedev leonidlebedev force-pushed the leonidlebedev:patch-1 branch from eff005f to 20c157d Jan 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment