New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jest.setup.js to import/no-extraneous-dependencies devDependencies #1998

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
2 participants
@tclindner
Copy link
Contributor

tclindner commented Jan 30, 2019

Hi team - Thank you for all of your excellent work on this project. 馃檶 I use Jest on a number of projects. A pattern Jest users utilize is moving setup to a separate jest.setup.js file. I would like to use devDependencies in this file without receiving an error from import/no-extraneous-dependencies. Would you be open to adding a new pattern to the import/no-extraneous-dependencies rule? Please let me know if you have questions or would like me to make changes. Thank you in advance!

@ljharb

ljharb approved these changes Feb 5, 2019

Copy link
Member

ljharb left a comment

i don't think this is a reigning convention, but sure, why not

@ljharb ljharb force-pushed the tclindner:add-jest-setup-file branch from a9e0ee3 to 96f95fa Feb 5, 2019

@ljharb ljharb merged commit 96f95fa into airbnb:master Feb 5, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@tclindner tclindner deleted the tclindner:add-jest-setup-file branch Feb 9, 2019

@tclindner

This comment has been minimized.

Copy link
Contributor Author

tclindner commented Feb 9, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment