Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jest.setup.js to import/no-extraneous-dependencies devDependencies #1998

Merged
merged 1 commit into from Feb 5, 2019

Conversation

tclindner
Copy link
Contributor

Hi team - Thank you for all of your excellent work on this project. 🙌 I use Jest on a number of projects. A pattern Jest users utilize is moving setup to a separate jest.setup.js file. I would like to use devDependencies in this file without receiving an error from import/no-extraneous-dependencies. Would you be open to adding a new pattern to the import/no-extraneous-dependencies rule? Please let me know if you have questions or would like me to make changes. Thank you in advance!

Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think this is a reigning convention, but sure, why not

@ljharb ljharb merged commit 96f95fa into airbnb:master Feb 5, 2019
@tclindner tclindner deleted the add-jest-setup-file branch February 9, 2019 02:03
@tclindner
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants