Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 19.9 bullet in a Whitespace section about multiple blank lines conventions #2017

Merged
merged 1 commit into from Mar 4, 2019

Conversation

Projects
None yet
2 participants
@Ensive
Copy link
Contributor

Ensive commented Feb 27, 2019

Add a 19.9 bullet in a Whitespace section with explanations about preventing two blank lines from appearing consecutively in a JavaScript code.

Closes #1048

[guide] Add a 19.9 bullet in a Whitespace section
- with explanations about preventing two blank lines from  appearing consecutively in JavaScript code
Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md Outdated

@ljharb ljharb added the editorial label Feb 27, 2019

@Ensive

This comment has been minimized.

Copy link
Contributor Author

Ensive commented Feb 27, 2019

@ljharb Updated PR according to review comments

@Ensive Ensive force-pushed the Ensive:enhance/add-section-with-explanations-about-avoiding-multiple-blanklines-in-js-code branch from 237c3f4 to 20fa904 Feb 27, 2019

@Ensive

This comment has been minimized.

Copy link
Contributor Author

Ensive commented Mar 2, 2019

Hi Jordan,
Any updates on this? @ljharb

@ljharb ljharb force-pushed the Ensive:enhance/add-section-with-explanations-about-avoiding-multiple-blanklines-in-js-code branch from 20fa904 to 2c39084 Mar 4, 2019

@ljharb

ljharb approved these changes Mar 4, 2019

@ljharb ljharb force-pushed the Ensive:enhance/add-section-with-explanations-about-avoiding-multiple-blanklines-in-js-code branch 2 times, most recently from 0e5235a to 60b96d3 Mar 4, 2019

@ljharb ljharb merged commit 60b96d3 into airbnb:master Mar 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Ensive Ensive deleted the Ensive:enhance/add-section-with-explanations-about-avoiding-multiple-blanklines-in-js-code branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.