Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eslint-plugin-react-hooks@2 #2090

Merged
merged 3 commits into from Feb 14, 2020
Merged

Support eslint-plugin-react-hooks@2 #2090

merged 3 commits into from Feb 14, 2020

Conversation

@perrin4869
Copy link
Contributor

perrin4869 commented Sep 16, 2019

Since #2083 was closed, I followed up, according to the changes requested there

@edmorley

This comment has been minimized.

Copy link
Contributor

edmorley commented Jan 27, 2020

@perrin4869 Hi! I don't suppose you could rebase on master? There are currently conflicts in packages/eslint-config-airbnb/package.json.

@perrin4869 perrin4869 force-pushed the perrin4869:master branch from 6ebd166 to 7f304ab Jan 28, 2020
@perrin4869

This comment has been minimized.

Copy link
Contributor Author

perrin4869 commented Jan 28, 2020

@edmorley just rebased! no problems there

Copy link
Contributor

edmorley left a comment

@perrin4869 Thank you for the rebase! Travis is failing at the moment, but I believe should succeed after the change below? :-)

- node_js: "6"
env: TEST=true ESLINT=5 PACKAGE=eslint-config-airbnb-base
- node_js: "6"
env: TEST=true ESLINT=5 PACKAGE=eslint-config-airbnb
- node_js: "6"
env: TEST=true ESLINT=5 REACT_HOOKS=1.7 PACKAGE=eslint-config-airbnb
exclude:
allow_failures:

This comment has been minimized.

Copy link
@edmorley

edmorley Jan 28, 2020

Contributor

I think the two new PREPUBLISH entries under include need equivalent entries under allow_failures here (since currently those runs are failing). eg:

    - env: PREPUBLISH=true ESLINT=6 REACT_HOOKS=1.7 PACKAGE=eslint-config-airbnb
    - env: PREPUBLISH=true ESLINT=5 REACT_HOOKS=1.7 PACKAGE=eslint-config-airbnb

This comment has been minimized.

Copy link
@ljharb

ljharb Jan 28, 2020

Collaborator

They don't; they're failing by design on master since new eslint rules have been released that haven't yet been added to the config. I'll rebase your PR after I've fixed it, you don't have to worry about it.

@mDibyo

This comment has been minimized.

Copy link

mDibyo commented Feb 12, 2020

Hello, happy Monday! what's the status of this PR? Anything I can do to help drive it forward?

@ljharb ljharb force-pushed the perrin4869:master branch from 7f304ab to b69c1ec Feb 13, 2020
@ljharb ljharb force-pushed the perrin4869:master branch from b69c1ec to 3493b06 Feb 14, 2020
@ljharb
ljharb approved these changes Feb 14, 2020
@ljharb ljharb merged commit 3493b06 into airbnb:master Feb 14, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.