Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable eslint rule `prefer-destructuring` internally #2110

Merged
merged 1 commit into from Oct 6, 2019

Conversation

@1pete
Copy link
Contributor

commented Oct 5, 2019

Previously eslint config of this repo disable rule prefer-destructuring because packages supported nodejs version 4.

But nodejs version 4 got support dropped recently, so this disablement is no longer needed.

@1pete 1pete force-pushed the 1pete:internal-eslint-config branch from 326f94d to 03c411a Oct 5, 2019
@ljharb
ljharb approved these changes Oct 6, 2019
Copy link
Collaborator

left a comment

thanks!

@ljharb ljharb force-pushed the 1pete:internal-eslint-config branch from 03c411a to 8f78e1f Oct 6, 2019
@ljharb ljharb merged commit 8f78e1f into airbnb:master Oct 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@1pete 1pete deleted the 1pete:internal-eslint-config branch Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.