Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint config][base][minor] enable `import/no-useless-path-segments` for commonjs #2113

Merged
merged 1 commit into from Oct 6, 2019

Conversation

@1pete
Copy link
Contributor

commented Oct 5, 2019

Currently config of rule import/no-useless-path-segments applies to only esmodule imports, this PR is to tighten it to apply to commonjs require as well to match the guide.

Resolves #2077

…s` for commonjs

Fixes #2077.
@ljharb ljharb force-pushed the 1pete:import-useless-path-segments-commonjs branch from b86c068 to 5a32c33 Oct 6, 2019
@ljharb
ljharb approved these changes Oct 6, 2019
@ljharb ljharb merged commit 5a32c33 into airbnb:master Oct 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@1pete 1pete deleted the 1pete:import-useless-path-segments-commonjs branch Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.