Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #2264

Closed
wants to merge 1 commit into from
Closed

Update README.md #2264

wants to merge 1 commit into from

Conversation

GilbertoDev
Copy link

No description provided.

ljharb
ljharb requested changes Aug 2, 2020
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the benefit of this change? It's just capitalizing some variables.

iamjatinchauhan
iamjatinchauhan reviewed Mar 17, 2021
View reviewed changes
Copy link

@iamjatinchauhan iamjatinchauhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalizing variable names not Required. camelCase is preferred for naming conventions.

@ljharb ljharb closed this Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamjatinchauhan iamjatinchauhan iamjatinchauhan left review comments

@ljharb ljharb ljharb requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GilbertoDev @ljharb @iamjatinchauhan