New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling boolValue instead of converting NSNumber #623

Merged
merged 2 commits into from Jun 28, 2018

Conversation

Projects
None yet
2 participants
@Garolla
Contributor

Garolla commented May 4, 2018

Problem found with static analysis code of Xcode 9.3.
"Converting a pointer value of type 'NSNumber *' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue"

Calling boolValue instead of converting NSNumber
Problem found with static analysis code of Xcode 9.3.
@buba447

A nil check should be performed here, not boolValue

Update LOTCompositionContainer.m
Changed to check for nil

@buba447 buba447 merged commit 21122a7 into airbnb:master Jun 28, 2018

@Garolla Garolla deleted the Garolla:patch-1 branch Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment