Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Rework DangerJS to work with forks. #25

Merged
merged 6 commits into from Apr 10, 2019

Conversation

Projects
None yet
2 participants
@milesj
Copy link
Contributor

milesj commented Apr 9, 2019

to: @stefhatcher @hayes @alecklandgraf

Description

Hardcode tokens in travis.yml since they aren't really private.

Motivation and Context

Danger tokens are currently stored in Travis settings, but these tokens are not available for forks (for security reasons).

Testing

Screenshots

Checklist

  • My code follows the style guide of this project.
  • I have updated or added documentation accordingly.
  • I have read the CONTRIBUTING document.
@ljharb

ljharb approved these changes Apr 9, 2019

Show resolved Hide resolved .travis.yml Outdated

milesj added some commits Apr 9, 2019

@milesj milesj merged commit 612b999 into master Apr 10, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
default All green. Congrats.
Details

@milesj milesj deleted the mj--danger-tokens branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.