3xx status codes should mean success #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously nerve considered 3xx to be failure, which is inconsistent with most other healthcheck systems (e.g. haproxy or nginx). Should fix #77
|
@igor47, @rickypai Do you guys have any opinions on this. If not I'm going to ship it. |
|
seems ok to me. update the test to include a 3xx case? |
|
@rickypai I don't believe there are any tests really ... which test are you thinking? |
|
I'm going to merge and follow up with a test when there are tests. |
jolynch
added a commit
that referenced
this pull request
Dec 7, 2015
3xx status codes should mean success
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously nerve considered 3xx to be failure, which is inconsistent
with most other healthcheck systems (e.g. haproxy or nginx).
Should fix #77