Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ref prop type #55

merged 1 commit into from Apr 7, 2019


None yet
2 participants
Copy link

ahuth commented Apr 5, 2019

This PR updates ref to:

  • Ensure that callback refs are not descendants of React.Component (should take care of PureComponent, as well, since those also extend Component).
  • Ensure that callback refs have a single argument
Show resolved Hide resolved src/ref.js
Show resolved Hide resolved test/ref.jsx
Copy link

ljharb left a comment

This looks great, thanks.

Show resolved Hide resolved src/ref.js

ljharb approved these changes Apr 7, 2019

@ljharb ljharb merged commit 3070a63 into airbnb:master Apr 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

@ahuth ahuth deleted the ahuth:refs-2 branch Apr 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.