New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] Add explicit overrides for test files #11

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
3 participants
@sharmilajesupaul
Copy link
Contributor

sharmilajesupaul commented Feb 1, 2019

Override global-require since there are valid use cases in the tests & run fix resulting lint violations.

My editor is a bloodbath without this @ljharb 馃槶
screen shot 2019-01-31 at 4 57 31 pm

@sharmilajesupaul sharmilajesupaul requested a review from ljharb Feb 1, 2019

Show resolved Hide resolved test/traversal/forEachDescriptor.js Outdated
Show resolved Hide resolved test/traversal/forEachDescriptor.js Outdated
Show resolved Hide resolved .eslintrc Outdated

@sharmilajesupaul sharmilajesupaul force-pushed the shar--add-eslint-overrides branch from d20bf6a to d7315a2 Feb 1, 2019

Show resolved Hide resolved .eslintrc Outdated
Show resolved Hide resolved .eslintrc Outdated

@sharmilajesupaul sharmilajesupaul force-pushed the shar--add-eslint-overrides branch from 85985f2 to 28ef66f Feb 1, 2019

Show resolved Hide resolved .eslintignore Outdated
Show resolved Hide resolved test/helpers/getDescriptorFromProvider.js

@sharmilajesupaul sharmilajesupaul force-pushed the shar--add-eslint-overrides branch from 95ca086 to e665474 Feb 1, 2019

@ljharb ljharb force-pushed the shar--add-eslint-overrides branch from e665474 to f2fe177 Feb 1, 2019

@ljharb

ljharb approved these changes Feb 1, 2019

@ljharb ljharb merged commit f2fe177 into master Feb 1, 2019

@ljharb ljharb deleted the shar--add-eslint-overrides branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment