New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move builder functions to a common helper #12

Merged
merged 1 commit into from Feb 2, 2019

Conversation

Projects
None yet
2 participants
@sharmilajesupaul
Copy link
Contributor

sharmilajesupaul commented Feb 2, 2019

Move yargs builder functions to a shared helper.

I'm not sure about the name, but it seems like this is doing a bunch of validation checks based on the config? so I called it validateCommand.

@sharmilajesupaul sharmilajesupaul requested a review from ljharb Feb 2, 2019

@ljharb

ljharb approved these changes Feb 2, 2019

Copy link
Member

ljharb left a comment

Beautiful, thanks.

@ljharb ljharb merged commit f10ab41 into master Feb 2, 2019

@ljharb ljharb deleted the shar--move-shared-builders branch Feb 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment