Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression] make sync hooks optional #18

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
3 participants
@sharmilajesupaul
Copy link
Contributor

sharmilajesupaul commented Mar 11, 2019

Make the sync field optional in the project config.

  • Add a snapshot test for custom error message.

@sharmilajesupaul sharmilajesupaul requested review from ljharb and madicap Mar 11, 2019

},
required: false,

This comment has been minimized.

@TaeKimJR

@ljharb ljharb force-pushed the shar--make-sync-hooks-optional branch from 6c8983d to 60ae1d8 Mar 11, 2019

@ljharb
Copy link
Member

ljharb left a comment

Please revert the snapshot testing.

@sharmilajesupaul sharmilajesupaul force-pushed the shar--make-sync-hooks-optional branch 2 times, most recently from 134cd02 to f4184d4 Mar 11, 2019

@sharmilajesupaul

This comment has been minimized.

Copy link
Contributor Author

sharmilajesupaul commented Mar 11, 2019

@ljharb removed the snapshot test

@sharmilajesupaul sharmilajesupaul force-pushed the shar--make-sync-hooks-optional branch from f4184d4 to ab2a768 Mar 11, 2019

@ljharb ljharb force-pushed the shar--make-sync-hooks-optional branch from ab2a768 to 3ac61b4 Mar 11, 2019

@ljharb ljharb merged commit 3ac61b4 into master Mar 11, 2019

@ljharb

ljharb approved these changes Mar 11, 2019

@ljharb ljharb deleted the shar--make-sync-hooks-optional branch Mar 11, 2019

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Mar 11, 2019

v0.3.2 released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.