Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Integrate with Happo.io #1382
Integrate with Happo.io
Happo.io is a screenshot testing service. It is used to find bugs,
I've been using react-dates for a while when stress-testing happo. One
Another important module here is
For now, we'll be taking screenshots in Chrome in two viewports:
Going forward, we may choose to add other targets/browsers as well. But
Here's what the current set of screenshots look like: https://happo.io/a/32/report/dev-267bf0c808a57df525b5 . There are a few known issues, some of which I'll work on fixing upstream and some that I think we'll just have to live with:
In order for this to get integrated with CI, I'm going to need help with a few things:
It looks like I also need help preventing failures in Node 4: https://travis-ci.org/airbnb/react-dates/builds/435084746?utm_source=github_status&utm_medium=notification. Happo doesn't support Node 4, and a dependency we use (puppeteer) is failing to install.
2 times, most recently
Oct 1, 2018
Alright, I'm at a place now where I'm ready for a review. Sorry for all the back-and-forth and force-pushes, I had to do some trial-and-error to get a few things to work. While doing so, I found a bug in the happo.io client (first-time run didn't work as expected). I've also noted down a few things I could improve on:
To view the full list of screenshots for this PR, go to https://happo.io/a/32/compare/6860b219f7f3b3d588e9745e470baf0afd17e4e5/3586d25b47af481e71f18375f9b9cc9b7d82352c?t=added
It looks like the regular
I can't make much of the error message:
(full log here: https://travis-ci.org/airbnb/react-dates/jobs/541444935)
It looks like others are running into this as well: #1595 (comment)
@lencioni any chance you can look into that?
@ljharb It does, but the happo-plugin-storybook plugin avoids the happo webpack build and uses a static storybook build instead.
I've got things working with Storybook version 5. Is there anything you see stopping us from getting on to the latest storybook version? If not I'll push a separate PR with that change.
Sorry for all the force-pushing. The last one was rebasing on master again after the Storybook v5 upgrade was merged.
I also had to resolve an issue with Storybook v5 and its usage of core-js. For anyone reviewing, it might be worth taking a look at 1561183 in isolation (lengthy commit message) and the Storybook issue that's related to the fix.