New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with Portal not including container elements. #1528

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@monokrome
Copy link
Contributor

monokrome commented Feb 5, 2019

After the 18.4.1 patch, we an issue has occurred where focusout always causes the day picker to close when a click occurs anywhere on the page - even within the day picker itself. This is because the <Portal> is being placed around the day picker instead of it's containers. This PR fixes that issue.

Thanks to @alvaro-cuesta for discovering this one and letting us know; fixes #1522

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 5, 2019

Coverage Status

Coverage increased (+0.05%) to 85.032% when pulling e286784 on bailey-bugfix-portal-containment into 277bed3 on master.

@ljharb
Copy link
Member

ljharb left a comment

There may need to be some test updates?

Show resolved Hide resolved src/components/DateRangePicker.jsx Outdated

monokrome added some commits Feb 5, 2019

@majapw

This comment has been minimized.

Copy link
Contributor

majapw commented Feb 6, 2019

@monokrome can you add some information about how the DOM structure is actually changed by this? You also mentioned there was a regression with the positioning of the calendar with this change; if that's still true, can you provide a screenshot of that behavior?

@monokrome monokrome requested a review from majapw Feb 7, 2019

@monokrome monokrome closed this Feb 7, 2019

@monokrome monokrome deleted the bailey-bugfix-portal-containment branch Feb 7, 2019

@monokrome monokrome restored the bailey-bugfix-portal-containment branch Feb 7, 2019

@monokrome monokrome reopened this Feb 7, 2019

@monokrome monokrome closed this Feb 7, 2019

@monokrome

This comment has been minimized.

Copy link
Contributor Author

monokrome commented Feb 7, 2019

Apparently github thinks this was closed, so opening another.

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Feb 7, 2019

Replaced by #1533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment