New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to demonstrate how logic of onDatesChange can affect onFocusChange #1529

merged 1 commit into from Feb 5, 2019


None yet
3 participants
Copy link

nkinser commented Feb 5, 2019

This PR adds tests to demonstrate that the order of onFocusChange and onDatesChange matters.

@ljharb @majapw

@nkinser nkinser force-pushed the nkinser:nk--add-tests-for-onFocusChange-and-onDatesChange-ordering branch from 2062e70 to 4076cc5 Feb 5, 2019


ljharb approved these changes Feb 5, 2019

Copy link

ljharb left a comment

Beautiful, thanks


This comment has been minimized.

Copy link

coveralls commented Feb 5, 2019

Coverage Status

Coverage remained the same at 84.984% when pulling 4076cc5 on nkinser:nk--add-tests-for-onFocusChange-and-onDatesChange-ordering into 277bed3 on airbnb:master.

@ljharb ljharb merged commit f596ba2 into airbnb:master Feb 5, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
coverage/coveralls Coverage remained the same at 84.984%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment