Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add positioning to custom navigation in stories #1573

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@dougmacknz
Copy link

dougmacknz commented Mar 7, 2019

Hi all, first time contributing here.

#1204 removed default styling on custom navigation buttons. This PR just fixes the positioning of all stories that have custom nav buttons by adding the positions to each example.

Closes #1532.

Before:
image

After:
image

Affected stories:
SDP - Calendar Props - with custom arrows
DayPicker - with custom arrows
DRP - Calendar Props - with custom month navigation
DRP - Calendar Props - vertical with custom month navigation
DayPickerSingleDateController - with custom month navigation
DayPickerRangeController - with custom navigation
DayPickerRangeController - with custom navigation and blocked navigation

Happy to do more clean ups in this area as well if desired. #1563 added a tabindex to custom nav elements but only one of the examples, and also a lot of the repeated 'prev' & 'next' styles can be DRY'ed up.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 7, 2019

Coverage Status

Coverage remained the same at 84.486% when pulling a813292 on dougmacknz:add-positioning-to-custom-nav-stories into 64c9857 on airbnb:master.

@ljharb

ljharb approved these changes Mar 7, 2019

@ljharb ljharb requested review from nkinser , majapw and monokrome Mar 7, 2019

@nkinser

nkinser approved these changes Mar 7, 2019

Copy link
Contributor

nkinser left a comment

LGTM!
Can you also please add tabIndex="0" to the custom navigation components that don't already have it?

@dougmacknz

This comment has been minimized.

Copy link
Author

dougmacknz commented Mar 7, 2019

Can you also please add tabIndex="0" to the custom navigation components that don't already have it?

Sure, all done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.