Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request for bug ticket #1575. #1577

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@WarrickPardoe
Copy link

WarrickPardoe commented Mar 11, 2019

Pull Request for bug ticket #1575.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 11, 2019

Coverage Status

Coverage increased (+0.05%) to 84.535% when pulling af6cd30 on WarrickPardoe:master into 64c9857 on airbnb:master.

@ljharb
Copy link
Member

ljharb left a comment

Could you provide some tests?

@WarrickPardoe

This comment has been minimized.

Copy link
Author

WarrickPardoe commented Mar 13, 2019

Sure, will look to get it done this weekend

@WarrickPardoe

This comment has been minimized.

Copy link
Author

WarrickPardoe commented Mar 18, 2019

I've updated the moment import to use the import with all the locales. I was having trouble trying to add the reset in the beforeEach callback, for some reason it was not resetting the locale correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.