Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add mindate maxdate props to daterangepicker #1582

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@pedroabreu
Copy link
Contributor

pedroabreu commented Mar 13, 2019

Adding minDate and maxDate props to the DateRangePicker component, to be able to disable navigation in the calendar.

The functionality was only implemented in the DateRangePickerController, which is rendered from DateRangePicker. This PR just adds the ability to set this props in the main react-dates component

@avivash
Copy link

avivash left a comment

LGTM, thanks for the quick turnaround on this!

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 13, 2019

Coverage Status

Coverage remained the same at 84.486% when pulling caff4ad on pedroabreu:feat/add_mindate_maxdate_props_to_daterangepicker into 32b5f3d on airbnb:master.

@ljharb
Copy link
Member

ljharb left a comment

Could you add tests and stories that use this functionality?

@pedroabreu

This comment has been minimized.

Copy link
Contributor Author

pedroabreu commented Mar 15, 2019

@ljharb added. Can't think of more tests to do, since the logic is already tested in DateRangePickerController.

Let me know if anything else needed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.