Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error message reporting verticalScrollable is not a valid orientation #1605

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@Kyngo
Copy link

Kyngo commented Apr 2, 2019

Title is self-descriptive. Got this error bugging me around and only could fix it that way.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 2, 2019

Coverage Status

Coverage remained the same at 84.494% when pulling 1be1e46 on Kyngo:master into 5f1964b on airbnb:master.

@ljharb
Copy link
Member

ljharb left a comment

This seems like a good change, but can we also add tests for all the components that use this shape?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.