Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: transform modules in karma so sinon can stub properly #1611

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@jrparish
Copy link
Contributor

jrparish commented Apr 8, 2019

This fixes all the failing tests when running using Karma.

sinonjs/sinon#1711

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 8, 2019

Coverage Status

Coverage remained the same at 84.494% when pulling 0ad49dd on jrparish:bugfix/karma-tests into 5f1964b on airbnb:master.

@ljharb
Copy link
Member

ljharb left a comment

Thanks! Can we also edit the travis config to make the karma tests required?

Show resolved Hide resolved karma.conf.js
@ljharb

ljharb approved these changes Apr 8, 2019

Copy link
Member

ljharb left a comment

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.