Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify that focusedInput: null constrains input #1745

Open
wants to merge 1 commit into
base: master
from

Conversation

@dcousens
Copy link

commented Aug 8, 2019

The original text reads as though the prop's presence is important, when really, it means, the prop's value.

@coveralls

This comment has been minimized.

Copy link

commented Aug 8, 2019

Coverage Status

Coverage remained the same at 84.887% when pulling 266745f on dcousens:patch-1 into 75bba6b on airbnb:master.

@@ -286,7 +286,7 @@ dayAriaLabelFormat: PropTypes.string,
#### DayPickerRangeController
The `DayPickerRangeController` is a calendar-only version of the `DateRangePicker`. There are no inputs (which also means
that currently, it is not keyboard accessible) and the calendar is always visible, but you can select a date range much in the same way you would with the `DateRangePicker`. You can control the selected
dates using the `startDate`, `endDate`, and `onDatesChange` props as shown below. Similarly, you can control which input is focused with the `focusedInput` and `onFocusChange` props as shown below. The user will only be able to select a date if `focusedInput` is provided.
dates using the `startDate`, `endDate`, and `onDatesChange` props as shown below. Similarly, you can control which input is focused with the `focusedInput` and `onFocusChange` props as shown below. The user will only be able to select a date if `focusedInput` is not `null`.

This comment has been minimized.

Copy link
@ljharb

ljharb Aug 8, 2019

Collaborator

Typically, a prop that’s null or undefined is considered “not provided” - I’m fine with this alternative wording, but it’d need to include undefined as well.

@ljharb ljharb added the documentation label Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.