Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] [deps] Update react-with-styles and other deps #1761

Merged
merged 5 commits into from Sep 10, 2019

Conversation

@noratarano
Copy link
Contributor

commented Aug 20, 2019

Summary

  • Update react-with-styles to latest version as well as a few other required deps.

Breaking changes:

  • [breaking][deps] Update all dependencies (drops node < 6)
  • [breaking] Set peer dep react-with-direction ^1.3.0 -> ^1.3.1
  • [breaking][deps] Move @babel/runtime to peer deps

Testing

Ran both storybooks (regular and css) and ran tests

Reviewers

@lencioni @ljharb @ahuth @indiesquidge @majapw @goatslacker

package.json Outdated Show resolved Hide resolved
const { whyDidYouUpdate } = require('why-did-you-update');
whyDidYouUpdate(React);
const whyDidYouRender = require('@welldone-software/why-did-you-render');
whyDidYouRender(React);

This comment has been minimized.

Copy link
@noratarano

noratarano Aug 20, 2019

Author Contributor

This fixes a bug where there were two version of React present.

This comment has been minimized.

Copy link
@noratarano

noratarano Sep 4, 2019

Author Contributor

It's no longer necessary, but it will save people lots of debugging time if they want to use hooks in this repo.

@coveralls

This comment has been minimized.

Copy link

commented Aug 20, 2019

Coverage Status

Coverage remained the same at 84.958% when pulling db4e194 on nora--update-react-with-styles into 2bf76ad on master.

@noratarano noratarano force-pushed the nora--update-react-with-styles branch from 08a3a1e to dbaa3b7 Aug 21, 2019

@ljharb
Copy link
Collaborator

left a comment

fwiw the only potential breaking part of this is the rws update

@noratarano

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

@ljharb Is it a requirement to add tests if I didn't make any changes 🤔

@noratarano noratarano force-pushed the nora--update-react-with-styles branch 3 times, most recently from 1419bc3 to fe79a98 Aug 23, 2019

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved

@noratarano noratarano force-pushed the nora--update-react-with-styles branch 2 times, most recently from 38bd2b2 to 8c748cd Aug 30, 2019

@ljharb ljharb changed the title [breaking][deps] Update all dependencies [breaking] [deps] Update all dependencies Aug 31, 2019

@ljharb

This comment has been minimized.

Copy link
Collaborator

commented Aug 31, 2019

What’s the breaking change in v4 alpha 1 of r-w-s?

@noratarano noratarano force-pushed the nora--update-react-with-styles branch from 8c748cd to 1dab51a Sep 4, 2019

@ljharb
ljharb approved these changes Sep 4, 2019
package.json Show resolved Hide resolved

@noratarano noratarano force-pushed the nora--update-react-with-styles branch from 1dab51a to f671ffb Sep 4, 2019

@noratarano noratarano changed the title [breaking] [deps] Update all dependencies [breaking] [deps] Update react-with-styles and other deps Sep 4, 2019

@noratarano

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

@ljharb The breaking change in RWS@4 is drop support for node 6, and added @babel/runtime as a peer dep.
https://github.com/airbnb/react-with-styles/blob/f7826233c6f3e994d33e200e63fd6d3f5d642e41/CHANGELOG.md#v400

@noratarano noratarano force-pushed the nora--update-react-with-styles branch from c0b3c42 to b6438b0 Sep 9, 2019

Nora Tarano added 4 commits Aug 30, 2019
Nora Tarano
[breaking][deps] Update all dependencies
- Drop support for node < 6
- Update: @storybook, webpack, react-with-styles, react-with-direction,
  react-with-styles-interface-aphrodite,
  react-with-styles-interface-css,
  react-with-styles-interface-css-compiler
Nora Tarano
[breaking] Set peer dep react-with-direction ^1.3.0 -> ^1.3.1
This is required to use react-with-styles@4.0.0

@noratarano noratarano force-pushed the nora--update-react-with-styles branch 2 times, most recently from 86875b3 to d4ea820 Sep 9, 2019

@noratarano noratarano force-pushed the nora--update-react-with-styles branch from d4ea820 to db4e194 Sep 9, 2019

@noratarano noratarano merged commit b1a933d into master Sep 10, 2019

4 checks passed

Tidelift Dependencies checked
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 84.958%
Details

@noratarano noratarano deleted the nora--update-react-with-styles branch Sep 10, 2019

@noratarano noratarano referenced this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.