Skip to content

Conversation

@jrparish
Copy link
Contributor

  • ariaInvalid allows for more accessible form validation
  • ariaDescribedby allows users to use custom elements for the field description instead of the built in screenReaderMessage behavior.

@jrparish jrparish force-pushed the feature/aria-attrs branch 2 times, most recently from 85e8f4d to 55485d0 Compare January 13, 2020 19:36
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on "allows for more accessible form validation"?

@ljharb ljharb requested a review from backwardok January 13, 2020 19:53
@jrparish
Copy link
Contributor Author

Can you elaborate on "allows for more accessible form validation"?

This attribute can be set to let a screen reader know a field is not valid.
For instance, a form may require a proper date. Say a user types in a partial date, which is invalid for the form, we would set aria-invalid to true to indicate to the user that the field is not correct.

Copy link
Contributor

@backwardok backwardok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me from the a11y side!

I'll let someone who's more familiar with the codebase at large to give the approval.

@ljharb ljharb added the semver-minor: new stuff Any feature or API addition. label Jan 14, 2020
@ljharb ljharb requested a review from nkinser January 14, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-minor: new stuff Any feature or API addition.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants