Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic for applying default navigation button styling #1898

Merged
merged 2 commits into from Jan 15, 2020

Conversation

@nkinser
Copy link
Contributor

nkinser commented Jan 14, 2020

Don't set isDefaultNavPrev or isDefaultNavNext to true if custom navigation buttons are provided.

Before

image

After

image

@nkinser nkinser requested review from ljharb, kevinthepan and majapw Jan 14, 2020
@nkinser nkinser force-pushed the nkinser:nk--fix-nav-default-styles branch from dfd5aec to 4c67f2b Jan 14, 2020
@nkinser nkinser changed the title Fix logic for apply default navigation button styling Fix logic for applying default navigation button styling Jan 14, 2020
@ljharb
ljharb approved these changes Jan 14, 2020
Copy link
Collaborator

ljharb left a comment

Any chance of a regression test?

@nkinser nkinser force-pushed the nkinser:nk--fix-nav-default-styles branch 2 times, most recently from 1dc1611 to 159e444 Jan 14, 2020
@nkinser nkinser force-pushed the nkinser:nk--fix-nav-default-styles branch 7 times, most recently from 4e844e9 to 05635fb Jan 14, 2020
@nkinser nkinser force-pushed the nkinser:nk--fix-nav-default-styles branch from 05635fb to 1057719 Jan 15, 2020
@nkinser nkinser merged commit 5a24a0b into airbnb:master Jan 15, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.4%) to 81.282%
Details
@nkinser nkinser deleted the nkinser:nk--fix-nav-default-styles branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.