Skip to content

Conversation

@wuweiweiwu
Copy link

@wuweiweiwu wuweiweiwu commented Mar 24, 2020

noticed that the title of the storybook is the default "storybook" so i decided to update the configurations! as https://www.npmjs.com/package/@storybook/addon-options is deprecated

blog post here: https://medium.com/storybookjs/declarative-storybook-configuration-49912f77b78

Changes:

  • created main.js preview.js manager.js for storybook and storybook-css
  • updated storybook-css to use full control mode (same webpack config as storybook)

Testing:

  • run yarn storybook[:css] and yarn gh-pages:build

Follow ups:

  • usage of withInfo needs to be updated. the current way is deprecated
  • configs between storybook and storybook-css is almost identical. webpack.config.js main.js and parts of preview.js can be shared

@wuweiweiwu wuweiweiwu closed this Jun 17, 2021
@ljharb
Copy link
Member

ljharb commented Jun 17, 2021

This still seems worth including at some point; we just haven't gotten to it. I'd prefer to leave it open, if that's alright.

@ljharb ljharb reopened this Jun 17, 2021
@wuweiweiwu
Copy link
Author

No problem! I can update to the latest storybook versions as well

@ljharb
Copy link
Member

ljharb commented Jun 24, 2021

Thanks, that’d be great!

@ljharb ljharb force-pushed the hwu/update-storybook branch from 8fc4f0a to 06b62de Compare November 30, 2021 00:15
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #1952 (06b62de) into master (3ddb7b5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1952   +/-   ##
=======================================
  Coverage   79.56%   79.56%           
=======================================
  Files          57       57           
  Lines        2285     2285           
  Branches      635      635           
=======================================
  Hits         1818     1818           
  Misses        274      274           
  Partials      193      193           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ddb7b5...06b62de. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants