Accessibility: added aria-hidden=true to navigation. #1957
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
(replacement for #1643, unless that one can be reopened) |
ljharb
added
the
accessibility
backwardok
reviewed
Mar 30, 2020
Contributor
backwardok
left a comment
backwardok
left a comment
There was a problem hiding this comment.
This change shouldn't need to be made. aria-hidden is not needed to prevent keyboard focus for IE. I mentioned this in the issue filed as well. The primary issue that was being run into before was that focusable="false" was getting stripped, which was fixed in a newer version of react-dates. In that issue, you found that upgrading did in fact no longer strip the focusable attribute, which should address your issue.
Author
@backwardok is it ok to close this PR, then? I am asking this in context of this comment from @ljharb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the
a11yissue described here: WordPress/gutenberg#15330