[Fix] CalendarMonthGrid: Fix iOS 14 navigation
#2051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Oct 3, 2020
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Is this already observable in tests or existing storybook examples?
|
Would be great to merge this soon, can't use transition in iOS14 at the moment. |
mgm793
approved these changes
Oct 19, 2020
Tronicnotes
approved these changes
Oct 22, 2020
ljharb
force-pushed
the
Fix-ios14-navigation
branch
from
55d1b28 to
4bf7d09
Compare
ljharb
approved these changes
Oct 31, 2020
ljharb
changed the title
CalendarMonthGrid: Fix iOS 14 navigation
ljharb
added
the
semver-patch: fixes/refactors/etc
|
Is the version that fixes this bug released ? I can’t find it |
|
I have add these code to fixed this bug, please see below, but I still find some problem that the animation is not smooth enough |
Member
|
No, it’s not. You can see that by clicking on the commit hash that closed the PR, and seeing there’s no release tags on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2034. Fixes #2050.
Just find out that there is some problems with
transition- adding some delay helped