Skip to content

[Fix] #1513 Replace sass-specific with runtime color calculation #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ljharb merged 4 commits into from
Oct 31, 2020
Merged

[Fix] #1513 Replace sass-specific with runtime color calculation #2058

ljharb merged 4 commits into from
Oct 31, 2020

Conversation

@11bit
Copy link
Contributor

@11bit 11bit commented Oct 30, 2020

Fixes #1513

  1. In generated css it replaces sass specific darken function with actual color.
  2. Also works in css-in-js mode by calculating colors in runtime

ljharb added 2 commits October 26, 2020 12:36
@ljharb
[meta] use mkdirp for windows compat
2bbbf50
@ljharb
[Deps] update airbnb-prop-types, enzyme-shallow-equal, `object.as…
c77b9a7 
…sign`, `object.values`, `react-moment-proptypes`, `react-outside-click-handler`, `react-portal`
@11bit 11bit mentioned this pull request Oct 30, 2020
Closed
ljharb
ljharb approved these changes Oct 31, 2020
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems great

@ljharb ljharb added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Oct 31, 2020
@ljharb ljharb merged commit 7a93b09 into react-dates:master Oct 31, 2020
@11bit
Copy link
Contributor Author

11bit commented Nov 2, 2020

Great, thanks!

@ljharb ljharb mentioned this pull request Jan 20, 2021
Closed
@ljharb
Copy link
Member

ljharb commented Feb 23, 2021

It’s very confusing how tests passed here in node 6, since color2k doesn’t even parse in node 6 :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes

Assignees

No one assigned

Labels

semver-patch: fixes/refactors/etc Anything that's not major or minor.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@11bit @ljharb