[Fix] DayPicker: update calendarMonthWeeks if numberOfMonths is changed
#2095
Conversation
|
This is a rebase of this pr: I have also manually tested with storybook and it seems the issue is fixed |
This comment has been minimized.
This comment has been minimized.
haojonat
force-pushed
the
updateCalendMonthWeeks
branch
from
32425b4 to
3c04660
Compare
haojonat
force-pushed
the
updateCalendMonthWeeks
branch
from
3c04660 to
f4ee7f0
Compare
This comment has been minimized.
This comment has been minimized.
…nged Fixes react-dates#1394. Co-authored-by: Lee Mulvey <lmulvey@me.com> Co-authored-by: Jonathan Hao <haojonat@amazon.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ljharb
force-pushed
the
updateCalendMonthWeeks
branch
2 times, most recently
from
3f6bd91 to
f42cfa8
Compare
|
It looks like the new tests aren't actually covering the new lines, so the coverage requirement isn't being met. |
haojonat
force-pushed
the
updateCalendMonthWeeks
branch
from
f42cfa8 to
7e3924a
Compare
ljharb
force-pushed
the
updateCalendMonthWeeks
branch
from
7e3924a to
fc988d6
Compare
|
@ljharb - noticed a case where the bug persists. will push another commit to address that as well as take another look at the tests |
|
@haojonat sounds great, thanks. |
haojonat
force-pushed
the
updateCalendMonthWeeks
branch
from
fc988d6 to
e5af62e
Compare
|
Why do the storybook knobs need to be removed? |
|
@ljharb - it was causing the REACT=15 builds to fail for some reason. /shrug |
|
found another way to fix that. |
ljharb
force-pushed
the
updateCalendMonthWeeks
branch
from
1bde514 to
42e5996
Compare
|
hi @ljharb, I just wanted to see if you were planning on updating the 21.8.0 release commit or creating a new 21.8.1 release based on latest? |
|
Releases can't ever be updated; they're immutable. This PR alone would constitute a patch release, but I'm not sure when the next release will be, nor what its version number. |
|
ah, darn, okay |
|
Hi @ljharb, do you know what does releasing a patch (or minor) depends on? |
4 participants
Fixes #1394.