Skip to content
Permalink
Branch: 0.46-canary
Commits on Jun 28, 2018
  1. v0.46.130

    gpeal committed Jun 28, 2018
  2. Merge pull request #55 from brynbodayle/bb/fishhook-import-fix-2

    gpeal committed Jun 28, 2018
    Fix for fishhook import take 2
Commits on Jun 27, 2018
Commits on Jun 26, 2018
  1. v0.46.129

    gpeal committed Jun 26, 2018
  2. Merge pull request #54 from brynbodayle/bb/fix-fishhook-import

    gpeal committed Jun 26, 2018
    Fixed fishhook import
  3. Fixed fishhook import

    brynbodayle committed Jun 26, 2018
Commits on Jun 25, 2018
  1. v0.46.128

    gpeal committed Jun 25, 2018
  2. Merge pull request #53 from brynbodayle/bb/prevent-web-socket-logging

    gpeal committed Jun 25, 2018
    [iOS] CherryPick - Prevent console logging on iOS 11.3+ within WebSocket
  3. Fixed whitespace changes

    brynbodayle committed Jun 25, 2018
  4. Prevent console logging on iOS 11.3+ within WebSocket

    brynbodayle committed Jun 25, 2018
    # Conflicts:
    #	RNTester/RNTester.xcodeproj/project.pbxproj
    #	RNTester/RNTesterLegacy.xcodeproj/project.pbxproj
Commits on Feb 14, 2018
  1. v0.46.127

    gpeal committed Feb 14, 2018
  2. v0.46.126

    gpeal committed Feb 14, 2018
  3. Merge pull request #52 from kierajmumick/km-cherrypicking-text-change

    gpeal committed Feb 14, 2018
    Cherrypicks Fix for Line Height Inconsistency Between iOS and Android
  4. Fix: incorrect line-height calculation

    strindhaug authored and Kieraj Mumick committed Feb 13, 2018
    Summary:
    There seems to be a rounding error in the android code for line height, so that for some fonts and at some combinations of line height and font size the actual height of the elements seems to be slightly too short.
    
    I've identified one issue that I mentioned here facebook#10712 (comment) that could at least explain some of the problem. That when the line-height minus the original sum of the absolute value of top  and bottom from the metrics, happens to be an odd number, the division by two causes a rounding error of 1, so that the actual line height is 1pt less than it should.
    
    The fix uses floating point division instead of integer division, and rounds (arbitrarily) the negative values up and the positive values down so that the total is still the correct for odd numbers.
    
    It turns out that only ascent and descent is used to give the actual line-height between lines in the same text-element. The top and bottom values are only used for padding the top and bottom of the text. So when the line-height is greater than the font size and the extra padding this PR sets the ascent and descent to the same value as the top and bottom respectively.
    
    I've renamed the shouldIncreaseAllMetricsProportionally test to evenLineHeightShouldIncreaseAllMetricsProportionally and added an extra assertion to check that bottom-top still equals the line height.
    
    Added another test oddLineHeightShouldAlsoWork that is similar but uses an odd number for the line height to test that it still works with odd numbers. This test only uses the sum of the values so that it's indifferent to what value the implementation chooses to round up or down.
    
    Improvement on facebook#16448
    
    Fix line-height calculation on Android.
    
    | Before        | After           |
    | ------------- |-------------|
    | ![without fix](https://user-images.githubusercontent.com/2144849/36150230-4404a0cc-10c3-11e8-8880-4ab84339c741.png)      | ![actual fix](https://user-images.githubusercontent.com/2144849/36156620-eb496d0e-10d7-11e8-8bd1-1cb536a38fbf.png) |
    
    (All three columns have font size 16 and lineHeight: 32. The first one is has fixed height 9*32, the second is 9 Text elements, the last is one text element with lots of text limited to 9 lines, so they should be the same height. )
    Closes facebook#17952
    
    Differential Revision: D6980333
    
    Pulled By: hramos
    
    fbshipit-source-id: 0a501358cfbf7f139fca46056d0d972b1daf6ae3
  5. Inverted descent/ascent Android prioritisation to match iOS lineHeigh…

    Bartol Karuza Kieraj Mumick
    Bartol Karuza authored and Kieraj Mumick committed Nov 6, 2017
    …t behaviour
    
    Summary:
    We noticed that on Android the lineHeight behaviour is different from iOS for built in fonts and custom fonts. The problem becomes visible when the lineHeight approaches the fontSize, showing a cut-off on the bottom of the TextView. This issue has been raised before in facebook#10712. There is a mention of a PR with a fix in that issue, which has not been merged yet. This implementation is a less intrusive fix leaving the current lineHeight approach in place and fixing the discrepancy only.
    
    This proposed change prioritises ascent over descent for reduction, making the lineHeight functionality behave identical to iOS.
    
    There is no existing test covering the lineHeight property and its behaviour in the CustomLineHeightSpan. This PR contains new unit tests that covers the various scenario's for the lineHeight calculations.
    
    The original behaviour, before the change can against these unit tests. The case that fails is `shouldReduceAscentThird`, which can be made to succeed on the old code by changing the asserts to:
    ```
        assertThat(fm.top).isEqualTo(-5);
        assertThat(fm.ascent).isEqualTo(-5);
        assertThat(fm.descent).isEqualTo(-4);
        assertThat(fm.bottom).isEqualTo(-4);
    ```
    The unit test succeeds for the current implementation, which has the values for ascent and descent inverted.
    
    Below screenshots show before, after and iOS:
    
    BEFORE
    ![screen shot 2017-10-18 at 15 35 41](https://user-images.githubusercontent.com/1605731/31721688-58d7086a-b41a-11e7-8186-9a201e2acb01.png)
    
    AFTER
    ![screen shot 2017-10-18 at 15 37 02](https://user-images.githubusercontent.com/1605731/31721665-473cf86c-b41a-11e7-94d5-7a70eaf99889.png)
    
    iOS
    ![screen shot 2017-10-18 at 15 35 22](https://user-images.githubusercontent.com/1605731/31721712-707e30a6-b41a-11e7-9baa-f886a66837e6.png)
    
    [ANDROID] [BUGFIX] [Text] - Fix the lineHeight behaviour on Android to match iOS
    Closes facebook#16448
    
    Differential Revision: D6221854
    
    Pulled By: andreicoman11
    
    fbshipit-source-id: 7292f0f05f212d79678ac9d73e8a46bf93f1a7c6
Commits on Feb 7, 2018
  1. Merge pull request #50 from airbnb/haitao-li-ios-reading-order

    gpeal committed Feb 7, 2018
    Revert "Fix VO reading order (#45)"
Commits on Feb 1, 2018
  1. Revert "Fix VO reading order (#45)"

    haitaoli committed Feb 1, 2018
    This reverts commit a9f4d02.
Commits on Jan 24, 2018
  1. v0.46.125

    gpeal committed Jan 24, 2018
  2. v0.46.124

    gpeal committed Jan 19, 2018
Commits on Jan 19, 2018
  1. Merge pull request #48 from airbnb/haitao-li--android-accessibilityco…

    gpeal committed Jan 19, 2018
    …mponenttype-crash
    
    Validate accessibilityComponentType data type
  2. v0.46.123

    gpeal committed Jan 19, 2018
  3. Merge pull request #47 from airbnb/haitao-li--remove-requestFocus-hack

    gpeal committed Jan 19, 2018
    Remove ReactEditText.requestFocus hack
  4. Remove requestFocus hack

    haitaoli committed Jan 19, 2018
Commits on Jan 4, 2018
  1. v0.46.122

    gpeal committed Jan 4, 2018
  2. Support more prop values in Android accessibilityComponentType (#46)

    haitaoli committed Jan 4, 2018
    * Android accessibility properties
    
    * Add checkbox and switch component types
Commits on Jan 3, 2018
  1. Fix VO reading order (#45)

    haitaoli committed Jan 3, 2018
Commits on Dec 15, 2017
  1. v0.46.121

    gpeal committed Dec 15, 2017
  2. Merge pull request #44 from airbnb/haitao-li--ios-textinput-accessibi…

    gpeal committed Dec 15, 2017
    …lity
    
    Motivation (required)
    This PR makes TextInput "clear text" button accessible. UITextField is wrapped inside a RCTextField (RCUITextField in latest version of RN) control which has isAccessibleElement set to TRUE. This prevents iOS accessibility interface to enumerate child elements. This change makes the RCTextField not accessible. But if the accessible prop is set to true, then it allows child elements to be enumerated.
  3. Merge pull request #43 from airbnb/revert-42-haitao-li--ios-textinput…

    gpeal committed Dec 15, 2017
    …-accessibility
    
    Revert "[iOS] Fix TextInput clear button accessibility"
Older
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.