Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak #20

Merged
merged 2 commits into from Jun 12, 2019

Conversation

Projects
None yet
3 participants
@tranvansang
Copy link
Contributor

commented Dec 17, 2018

Fix: Memory leak occurs if mousedown is fired, but mouseup won't

@Superoryco

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

Still not covered in 1.2.3? This fix has really helped when user drag something instead of click, which will then cause multiple fire onOutsideClick(e)

@ljharb
Copy link
Member

left a comment

Could you please add a regression test?

@ljharb ljharb force-pushed the tranvansang:patch-1 branch from 2e74195 to 03230cc Jun 12, 2019

@ljharb

ljharb approved these changes Jun 12, 2019

Copy link
Member

left a comment

Brought in a regression test from #25.

@ljharb ljharb merged commit 84df35b into airbnb:master Jun 12, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.