New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't run basic-setup example #213

Closed
LincMitch opened this Issue Dec 7, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@LincMitch

LincMitch commented Dec 7, 2017

I am...
Reporting a bug or issue
-------------------------------------------------------------------------------------------------

Expected behavior:
Run basic-setup example successfully.

Observed behavior:
I get this error:
TypeError: MSAttributedString.alloc().initWithAttributedString is not a function. (In 'MSAttributedString.alloc().initWithAttributedString(attribStr)', 'MSAttributedString.alloc().initWithAttributedString' is undefined)
line: 2813
sourceURL: /Users/lincolnmitchel/Documents/react-sketchapp-1.0.0-beta.5/examples/basic-setup/basic-setup.sketchplugin/Contents/Sketch/my-command.js
column: 72
stack: makeAttributedString@/Users/lincolnmitchel/Documents/react-sketchapp-1.0.0-beta.5/examples/basic-setup/basic-setup.sketchplugin/Contents/Sketch/my-command.js:2813:72
makeTextLayer@/Users/lincolnmitchel/Documents/react-sketchapp-1.0.0-beta.5/examples/basic-setup/basic-setup.sketchplugin/Contents/Sketch/my-command.js:15026:66
renderBackingLayers@/Users/lincolnmitchel/Documents/react-sketchapp-1.0.0-beta.5/examples/basic-setup/basic-setup.sketchplugin/Contents/Sketch/my-command.js:14977:44
flexToSketchJSON@/Users/lincolnmitchel/Documents/react-sketchapp-1.0.0-beta.5/examples/basic-setup/basic-setup.sketchplugin/Contents/Sketch/my-command.js:6061:51
map@[native code]
flexToSketchJSON@/Users/lincolnmitchel/Documents/react-sketchapp-1.0.0-beta.5/examples/basic-setup/basic-setup.sketchplugin/Contents/Sketch/my-command.js:6063:31
map@[native code]
flexToSketchJSON@/Users/lincolnmitchel/Documents/react-sketchapp-1.0.0-beta.5/examples/basic-setup/basic-setup.sketchplugin/Contents/Sketch/my-command.js:6063:31
renderToSketch@/Users/lincolnmitchel/Documents/react-sketchapp-1.0.0-beta.5/examples/basic-setup/basic-setup.sketchplugin/Contents/Sketch/my-command.js:4967:45
/Users/lincolnmitchel/Documents/react-sketchapp-1.0.0-beta.5/examples/basic-setup/basic-setup.sketchplugin/Contents/Sketch/my-command.js:7165:30
run@/Users/lincolnmitchel/Documents/react-sketchapp-1.0.0-beta.5/examples/basic-setup/basic-setup.sketchplugin/Contents/Sketch/my-command.js:18795:17
run@[native code]

How to reproduce:
Installed a clean version of react-sketch app and run Basic-Setup.

Versions:
SketchApp 48
skpm 1.0.10
npm 5.5.1
OS 10.12.6

KimDal-hyeong added a commit to KimDal-hyeong/react-sketchapp that referenced this issue Dec 7, 2017

fix airbnb#213
`initWithAttributedString` is undefined in version 48.
I used `initWithEncodedAttributedString` instead of `initWithAttributedString`.

@KimDal-hyeong KimDal-hyeong referenced this issue Dec 7, 2017

Merged

fix #213 #214

@dericgw

This comment has been minimized.

dericgw commented Dec 7, 2017

@LincMitch It looks like there is an issue with this working with Skecth 48. You can download Sketch 47 here if you want to get up and going with it until a fix is applied.

KimDal-hyeong added a commit to KimDal-hyeong/react-sketchapp that referenced this issue Dec 7, 2017

fix airbnb#213
`initWithAttributedString` is undefined in version 48.
I used `initWithEncodedAttributedString` instead of `initWithAttributedString`.
@LincMitch

This comment has been minimized.

LincMitch commented Dec 7, 2017

Thx @dericgw. With Sketch 47 it works fine.

thierryc added a commit to anotherplanet-io/react-sketchapp that referenced this issue Dec 7, 2017

@jongold jongold closed this in 6bd3526 Dec 15, 2017

jongold added a commit that referenced this issue Dec 18, 2017

Update dependencies examples/symbols react-sketchapp 1.0.0 (#223)
* fix #213

`initWithAttributedString` is undefined in version 48.
I used `initWithEncodedAttributedString` instead of `initWithAttributedString`.

* update dependencies

"react": "^16.2.0",
"react-sketchapp": "^1.0.0",
"react-test-renderer": "^16.2.0"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment