Fix for incorrect radius when exporting to SVG #69
+24
−20
Conversation
dchen
requested a review
from jongold
May 3, 2017
|
@dchen would you mind rebasing on the command line so there's no merge commits? |
| export const makeShapeGroup = ( | ||
| frame: SJRect, | ||
| layers: Array<any> = [], | ||
| - fills?: Array<SJFill> = [], | ||
| + fills?: Array<SJFill> = [] |
|
I rebased. Regarding the comma dangling, the pre-commit hook is removing that automatically. Is there some config I need to change to prevent that from happening? |
|
Weird, I'll look into the config :/
|
|
I'm not sure; I generally avoid pre-commit hooks entirely since they aren't run in CI, and just like editor integrations, are only useful for devs themselves. |
|
I updated my commit without running the pre-commit hook. Please take another look. Thanks! |
ljharb
dismissed
their
review
May 3, 2017
linting error resolved
jongold
merged commit 0b3a294 into airbnb:master May 3, 2017
dchen
deleted the
dchen:fixed-radius-bug branch
May 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dchen commentedMay 3, 2017
Closes #67