Fix for incorrect radius when exporting to SVG #69

Merged
merged 1 commit into from May 3, 2017

Conversation

Projects
None yet
3 participants
Contributor

dchen commented May 3, 2017

Closes #67

dchen requested a review from jongold May 3, 2017

Owner

ljharb commented May 3, 2017

@dchen would you mind rebasing on the command line so there's no merge commits?

src/jsonUtils/shapeLayers.js
export const makeShapeGroup = (
frame: SJRect,
layers: Array<any> = [],
- fills?: Array<SJFill> = [],
+ fills?: Array<SJFill> = []
@ljharb

ljharb May 3, 2017

Owner

our style guide requires trailing commas, on functions as well

Contributor

dchen commented May 3, 2017

I rebased.

Regarding the comma dangling, the pre-commit hook is removing that automatically. Is there some config I need to change to prevent that from happening?

Member

jongold commented May 3, 2017 edited by ljharb

Owner

ljharb commented May 3, 2017

I'm not sure; I generally avoid pre-commit hooks entirely since they aren't run in CI, and just like editor integrations, are only useful for devs themselves.

Contributor

dchen commented May 3, 2017

I updated my commit without running the pre-commit hook. Please take another look. Thanks!

@#{review_dismissed_event.actor.login} ljharb dismissed their review May 3, 2017

linting error resolved

@jongold

jongold approved these changes May 3, 2017 View changes

:shipit:

jongold merged commit 0b3a294 into airbnb:master May 3, 2017

dchen deleted the dchen:fixed-radius-bug branch May 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment