Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new][deps] Include react-with-styles@4.0.0 in peer deps #9

Merged
merged 2 commits into from Sep 4, 2019

Conversation

@noratarano
Copy link
Contributor

commented Sep 4, 2019

@noratarano

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

@ljharb Can this be merged before v4 of RWS is published?

@noratarano noratarano changed the title [deps] Include react-with-styles@4.0.0 in peer deps [new][deps] Include react-with-styles@4.0.0 in peer deps Sep 4, 2019

@noratarano noratarano changed the title [new][deps] Include react-with-styles@4.0.0 in peer deps [fix][deps] Include react-with-styles@4.0.0 in peer deps Sep 4, 2019

@noratarano noratarano requested a review from ljharb Sep 4, 2019

@noratarano

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

RWS version 4 has been published, so we can merge :) PTAL
@ljharb @TaeKimJR @ahuth @indiesquidge @joeuy @majapw @lencioni

package.json Show resolved Hide resolved

@noratarano noratarano added semver-minor and removed semver-patch labels Sep 4, 2019

@ljharb
ljharb approved these changes Sep 4, 2019

@noratarano noratarano force-pushed the nora--rws-4 branch from 7b7853d to e8314c5 Sep 4, 2019

@noratarano noratarano changed the title [fix][deps] Include react-with-styles@4.0.0 in peer deps [new][deps] Include react-with-styles@4.0.0 in peer deps Sep 4, 2019

@noratarano noratarano merged commit 95c6b28 into master Sep 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@noratarano noratarano deleted the nora--rws-4 branch Sep 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.