Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new][deps] react-with-styles-interface-css ^4.0.3 -> ^5.0.0 #22

Merged
merged 1 commit into from Sep 4, 2019

Conversation

@noratarano
Copy link
Collaborator

commented Sep 4, 2019

Summary

Update react-with-styles-interface-css@5.0.0 in peer deps:
https://github.com/airbnb/react-with-styles-interface-css/releases/tag/interface-v5.0.0

All this does is add v4.0.0 of react-with-styles to peer deps.

Reviewers

@ljharb @TaeKimJR @ahuth @indiesquidge @joeuy @majapw @lencioni

@ahuth
ahuth approved these changes Sep 4, 2019
Copy link

left a comment

LGTM

@ljharb
ljharb approved these changes Sep 4, 2019
@noratarano

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 4, 2019

@ljharb How do I make Tidelift finish its work? 🤔 I don't think I have access to that tool.

@noratarano noratarano merged commit 4ee242a into master Sep 4, 2019

2 of 3 checks passed

Tidelift Scanning dependencies
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@noratarano noratarano deleted the nora--update-interface-5 branch Sep 4, 2019

@ljharb

This comment has been minimized.

Copy link
Collaborator

commented Sep 4, 2019

@noratarano hm, ideally it doesn't take long - but either way it's not required, so you can always merge past it. if it ends up being slow, i'll file a bug with them directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.