Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move checking performance marks to separate file #217

Conversation

Projects
None yet
4 participants
@mmarkelov
Copy link

commented Jul 4, 2019

I suppose may be it will be a good idea to move performance checking logic to separate file helper

mapkeji added some commits Jul 4, 2019

@@ -31,22 +33,14 @@ function get() {
}

function resolve(...styles) {
if (
process.env.NODE_ENV !== 'production'

This comment has been minimized.

Copy link
@ljharb

ljharb Jul 4, 2019

Collaborator

The tradeoff here is that now bundlers can’t delete the code, they have to always import a function and call it.

This comment has been minimized.

Copy link
@lencioni

lencioni Jul 8, 2019

Member

Agreed, I think we should leave this inline so that it can be completely minified out in production builds.

This comment has been minimized.

Copy link
@mmarkelov

mmarkelov Jul 9, 2019

Author

Thank you for your feedback. I wanted to keep it just a little bit cleaner. But now I understand that it was not the best approach

This comment has been minimized.

Copy link
@lencioni

lencioni Jul 9, 2019

Member

Thanks for the PR!

@mmarkelov mmarkelov closed this Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.