Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date example to work with IOS #236

Open
wants to merge 2 commits into
base: master
from

Conversation

@mmarkelov
Copy link

commented Aug 3, 2019

Date example does not work in Safari and IOS devices:
bug

@@ -129,8 +129,8 @@ storiesOf('Slider', module)
);
})
.add('Dates', () => {
const startDate = new Date('01-01-2015').valueOf();

This comment has been minimized.

Copy link
@ljharb

ljharb Aug 3, 2019

Collaborator

This is also broken in Safari; another alternative is using slashes instead of dashes - maybe we should go with that?

This comment has been minimized.

Copy link
@mmarkelov

mmarkelov Aug 4, 2019

Author

@ljharb I just fix date constructor (I forgot that dates start from 0), and seems like it's ok now:
safari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.