From 16dc0e1f1d99da17853788e87aeba82f59bfffb7 Mon Sep 17 00:00:00 2001 From: Allen Kerr Date: Wed, 27 Jun 2018 09:25:49 -0700 Subject: [PATCH] Upgrade rubocop-rspec to 1.27.0 --- rubocop-airbnb/config/rubocop-rspec.yml | 36 ++++++++++++++++++++++++- rubocop-airbnb/rubocop-airbnb.gemspec | 2 +- 2 files changed, 36 insertions(+), 2 deletions(-) diff --git a/rubocop-airbnb/config/rubocop-rspec.yml b/rubocop-airbnb/config/rubocop-rspec.yml index 030adc2..16b1ea6 100644 --- a/rubocop-airbnb/config/rubocop-rspec.yml +++ b/rubocop-airbnb/config/rubocop-rspec.yml @@ -17,6 +17,10 @@ RSpec/AroundBlock: Description: Checks that around blocks actually run the test. Enabled: true +RSpec/Be: + Description: Check for expectations where `be` is used without argument. + Enabled: true + RSpec/BeEql: Description: Check for expectations where `be(...)` can replace `eql(...)`. Enabled: false @@ -30,6 +34,7 @@ RSpec/BeforeAfterAll: - spec/support/**/*.rb RSpec/ContextWording: + Description: "`context` block descriptions should start with 'when', or 'with'." Enabled: false RSpec/DescribeClass: @@ -53,10 +58,18 @@ RSpec/EmptyExampleGroup: Enabled: true CustomIncludeMethods: [] +RSpec/EmptyLineAfterExampleGroup: + Description: Checks if there is an empty line after example group blocks. + Enabled: true + RSpec/EmptyLineAfterFinalLet: Description: Checks if there is an empty line after the last let block. Enabled: true +RSpec/EmptyLineAfterHook: + Description: Checks if there is an empty line after hook blocks. + Enabled: true + RSpec/EmptyLineAfterSubject: Description: Checks if there is an empty line after subject block. Enabled: true @@ -159,6 +172,7 @@ RSpec/LetBeforeExamples: Enabled: true RSpec/LetSetup: + Description: Checks unreferenced `let!` calls being used for test setup. Enabled: false RSpec/MessageChain: @@ -215,6 +229,10 @@ RSpec/OverwritingSetup: Enabled: false Description: Checks if there is a let/subject that overwrites an existing one. +RSpec/Pending: + Description: Checks for any pending or skipped examples. + Enabled: false + RSpec/PredicateMatcher: Description: Prefer using predicate matcher over using predicate method directly. Enabled: false @@ -224,9 +242,13 @@ RSpec/PredicateMatcher: - inflected - explicit +RSpec/ReceiveCounts: + Description: Check for `once` and `twice` receive counts matchers usage. + Enabled: false + RSpec/RepeatedDescription: - Enabled: true Description: Check for repeated description strings in example groups. + Enabled: true RSpec/RepeatedExample: Enabled: true @@ -252,6 +274,10 @@ RSpec/SharedContext: Description: Checks for proper shared_context and shared_examples usage. Enabled: false +RSpec/SharedExamples: + Description: Enforces use of string to titleize shared examples. + Enabled: true + RSpec/SingleArgumentMessageChain: Description: Checks that chains of messages contain more than one element. Enabled: true @@ -276,6 +302,14 @@ Capybara/FeatureMethods: Description: Checks for consistent method usage in feature specs. Enabled: false +FactoryBot/CreateList: + Description: Checks for create_list usage. + Enabled: true + FactoryBot/DynamicAttributeDefinedStatically: Description: Prefer declaring dynamic attribute values in a block. Enabled: true + +FactoryBot/StaticAttributeDefinedDynamically: + Description: Prefer declaring static attribute values without a block. + Enabled: false diff --git a/rubocop-airbnb/rubocop-airbnb.gemspec b/rubocop-airbnb/rubocop-airbnb.gemspec index 8965894..41c0224 100644 --- a/rubocop-airbnb/rubocop-airbnb.gemspec +++ b/rubocop-airbnb/rubocop-airbnb.gemspec @@ -26,6 +26,6 @@ Gem::Specification.new do |spec| ] spec.add_dependency('rubocop', '0.57.2') - spec.add_dependency('rubocop-rspec', '1.22.1') + spec.add_dependency('rubocop-rspec', '1.27.0') spec.add_development_dependency('rspec', '~> 3.5') end