make stack trace more readable #1672

Merged
merged 3 commits into from Nov 29, 2016

Projects

None yet

2 participants

@ascott
Collaborator
ascott commented Nov 23, 2016

although the ascii art is DOPE, i think it would be great if we, and our users, can see the stacktrace more easily/quickly.

before:
screenshot 2016-11-22 17 53 29

after:
screenshot 2016-11-22 17 55 15

plz review @airbnb/superset-reviewers

ascott added some commits Nov 23, 2016
@ascott ascott make stack trace more readable
75dd531
@ascott ascott remove ascii_art import
c278c63
@mistercrunch
Contributor

might as well git rm super/ascii_art.py there's also a leftover boat in there we should remove along with reference(s) to it.

@ascott ascott remove ascii_art.py
5a8c62a
@ascott
Collaborator
ascott commented Nov 29, 2016

@mistercrunch thx for the review. removed ascii_art.py and references to it.

@ascott ascott merged commit 3496a80 into airbnb:master Nov 29, 2016

3 of 4 checks passed

code-quality/landscape Code quality decreased by -0.03%
Details
codeclimate Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.08%) to 79.804%
Details
@ascott ascott deleted the ascott:alanna-traceback-template branch Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment