Fix handling of Chunked requests #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishantmonu51
force-pushed
the
fix-chunk-encoding
branch
from
2693b93
to
3f82d97
Compare
Add fix for handling chunk encoding requests. If ENABLE_CHUNK_ENCODING is set to true, for requests with transfer encoding set to true. It will set wsgi.input_terminated to true which tells werkzeug to ignore content-length and read the stream till the end. break comment in multiple lines
nishantmonu51
force-pushed
the
fix-chunk-encoding
branch
from
3f82d97
to
fff280b
Compare
xrmx
reviewed
Dec 2, 2016
superset/__init__.py
Outdated
| def __call__(self, environ, start_response): | ||
| # Setting wsgi.input_terminated tells werkzeug.wsgi to ignore | ||
| # content-length and read the stream till the end. | ||
| print(environ) |
|
@xrmx Any more comments ? |
|
@xrmx: Any more comments on this ? |
|
@nishantmonu51 nope, looks fine to me |
|
@xrmx: can this be merged then ? do i need to contact someone else for getting this in ? |
|
@mistercrunch: please review. |
|
LGTM |
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Jun 13, 2017
* Fix handling of Chunked requests Add fix for handling chunk encoding requests. If ENABLE_CHUNK_ENCODING is set to true, for requests with transfer encoding set to true. It will set wsgi.input_terminated to true which tells werkzeug to ignore content-length and read the stream till the end. break comment in multiple lines * remove debug print logging
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fix for handling chunk encoding requests.
If ENABLE_CHUNK_ENCODING is set to true, for requests with transfer
encoding set to true. It will set wsgi.input_terminated to true which
tells werkzeug to ignore content-length and read the stream till the
end.
Fixes #1720