watcher for Apache Aurora zookeeper announcements #104
Conversation
Aurora zookeeper serversets are similar to what Nerve does, but Aurora uses a different json structure in the zookeeper nodes, and it has provisions for more than one advertised port for a service. Change-Id: I55303bd68677706146dcfef267e625ffea1e80f3
|
@benley I like your implementation, allowing a custom port_name, since the rest is exactly the same, I'll merge yours into mine. |
|
Anything missing to get this one merged? |
|
I can update this to fit the new plugin model pretty easily if there's actually a chance of getting it merged. |
|
Yes I'm trying to work my way through the pull requests. If you pull/rebase I can review this one next. I think Igor is handling review of the exhibitor watcher, and we have a few more to review. |
|
@benley two minor remarks:
Really looking forward to seeing this merged. Thanks for your effort 👍 |
|
I agree about renaming it to serverset watcher; I'll get the PR updated soon. |
| # "port": 31943 | ||
| # }, | ||
| # "shard": 0, | ||
| # "status": "ALIVE" |
There was a problem hiding this comment.
Should we take into account the ALIVE status?
There was a problem hiding this comment.
Looking at Aurora, I am not sure if the status is ever toggled. Aurora seems to simply remove the znode when the registered server disconnects. I'd say we leave it out for now.
|
See #144 for the current deserialize interface |
|
I'm planning on working on this PR tomorrow afternoon-ish, fwiw |
|
I believe that #153 should support what this PR requests via the new If that doesn't work please open and issue/PR and we can work on it :-) |
|
Thanks for finishing this work, @jolynch! I got buried with other projects and totally lost track of it. |
Aurora zookeeper serversets are comparable to what Nerve does, but Aurora uses a different json structure in the zookeeper nodes, and it has provisions for more than one advertised port for a service.